Help us understand the problem. What is going on with this article?

GitHubのレビューでコード提案をする便利機能を試してみた

More than 1 year has passed since last update.

GitHubのレビューでコード提案をする便利機能を試してみた

New! Suggest specific code changes that the pull request author can immediately commit. You will be attributed in the commit.

今日PRをレビューしていると以下のメッセージが出たので新機能を使ってみた記事です。内容は薄いです。

Screenshot from 2018-10-17 11-00-47.png

Screenshot from 2018-10-17 11-17-03.png

PRの作成者がその変更を受け入れる Apply suggestion とコミットメッセージが聞かれるので Commit changes でコミットしましょう。

Screenshot from 2018-10-17 11-19-12.png

コミットされておしまい。

ykhirao
Web Developer For 3 years. PHP/Laravel && (React OR Vue.js)
Why not register and get more from Qiita?
  1. We will deliver articles that match you
    By following users and tags, you can catch up information on technical fields that you are interested in as a whole
  2. you can read useful information later efficiently
    By "stocking" the articles you like, you can search right away
Comments
No comments
Sign up for free and join this conversation.
If you already have a Qiita account
Why do not you register as a user and use Qiita more conveniently?
You need to log in to use this function. Qiita can be used more conveniently after logging in.
You seem to be reading articles frequently this month. Qiita can be used more conveniently after logging in.
  1. We will deliver articles that match you
    By following users and tags, you can catch up information on technical fields that you are interested in as a whole
  2. you can read useful information later efficiently
    By "stocking" the articles you like, you can search right away
ユーザーは見つかりませんでした