Help us understand the problem. What is going on with this article?

jQuery アコーディオン

More than 3 years have passed since last update.

アコーディオン

jsめも
所謂アコーディオンとかいう
dt押したらddでてきて、その中に閉じるボタンがある的なやつ
toggle使うだけでいけそうだけど、ボタンのアイコンとか変えるのにif文がいるんだったと思う

js
$(function(){

    var dt = $(".js-dt");
    var dd = $(".js-dd");
    var _close = $(".js-close a");
    dd.hide();
    dt.click(function(){
        var _this_dt = $(this).parents("dl").children("dt");
        var _this_dd = $(this).parents("dl").children("dd");
        if(_this_dd.css('display') != 'none'){
            _this_dd.slideUp(function(){
                _this_dt.removeClass("active");
            });
        }else{
            _this_dt.addClass("active");
            _this_dd.slideDown();
        };
    });
    _close.click(function(){
        var _this_dt = $(this).parents("dl").children("dt");
        var _this_dd = $(this).parents("dl").children("dd");
        _this_dd.slideUp(function(){
            _this_dt.removeClass("active");
        });
    });
});

って超絶ムダなスクリプトかいてたのを修正

js
$(function(){
    $(".js-dd").hide();
    $(".js-dt, .js-close a").click(function(){
        var _this_dt = $(this).parents("dl").children("dt");
        var _this_dd = $(this).parents("dl").children("dd");
        if(_this_dd.css('display') === 'none'){
            _this_dt.addClass("active");
            _this_dd.slideDown();
        }else{
            _this_dd.slideUp(function(){
                _this_dt.removeClass("active");
            });
        };
    });
});

if文はif(hoge.css('display') != 'none')よりif(hoge.css('display') === 'none')の方がわかりやすいかも
parentsとchildrenがキモい。.each()使ったらいいとおもうけど、とりあえずここまで

Why not register and get more from Qiita?
  1. We will deliver articles that match you
    By following users and tags, you can catch up information on technical fields that you are interested in as a whole
  2. you can read useful information later efficiently
    By "stocking" the articles you like, you can search right away
Comments
No comments
Sign up for free and join this conversation.
If you already have a Qiita account
Why do not you register as a user and use Qiita more conveniently?
You need to log in to use this function. Qiita can be used more conveniently after logging in.
You seem to be reading articles frequently this month. Qiita can be used more conveniently after logging in.
  1. We will deliver articles that match you
    By following users and tags, you can catch up information on technical fields that you are interested in as a whole
  2. you can read useful information later efficiently
    By "stocking" the articles you like, you can search right away
ユーザーは見つかりませんでした